Skip to content

Push get_item through wrapper arrays - #9719

Merged
danking merged 1 commit into
developfrom
dk/get-item-wrapper-pushdown
Sep 3, 2026
Merged

Push get_item through wrapper arrays#9719
danking merged 1 commit into
developfrom
dk/get-item-wrapper-pushdown

Conversation

@danking

@danking danking commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • push GetItem through Filter wrappers as Filter(GetItem(child), mask)
  • push GetItem through Slice wrappers as Slice(GetItem(child), range)
  • push GetItem through Masked wrappers as Mask(GetItem(child), masked_validity)
  • add regression tests for all three wrapper cases

Tests

  • cargo +nightly fmt --all
  • cargo test -p vortex-array scalar_fn::fns::get_item::tests

@danking danking added the changelog/performance A performance improvement label Sep 1, 2026
@danking
danking enabled auto-merge (squash) September 1, 2026 17:34
@codspeed-hq

codspeed-hq Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 1 regressed benchmark
✅ 2170 untouched benchmarks
⏩ 206 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation random_i8[0.5] 67.2 µs 90.8 µs -25.98%
⚡ Simulation random_i16[0.8] 92.1 µs 74.2 µs +24.17%
⚡ Simulation compact_sliced[(1024, 90)] 1.5 µs 1.3 µs +21.84%
⚡ WallTime arrow_checked_add_u32_avx2[16384] 21.4 µs 17.6 µs +21.42%
⚡ Simulation decompress[u64, (4000, 1024)] 85.7 µs 70.8 µs +21.11%
⚡ Simulation compact_sliced[(2048, 90)] 1.6 µs 1.3 µs +20.87%
⚡ Simulation allocate_drop_arrow[0] 456.9 ns 402.7 ns +13.45%
⚡ Simulation compact[(1024, 90)] 1.5 µs 1.3 µs +12.65%
⚡ WallTime mul_u32_nonnull_avx512 6.3 µs 5.6 µs +12.22%
⚡ Simulation compact[(2048, 90)] 1.5 µs 1.4 µs +12.1%
⚡ Simulation allocate_drop_bytes[0] 520.2 ns 466 ns +11.62%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing dk/get-item-wrapper-pushdown (60a587f) with develop (dab1684)

Open in CodSpeed

Footnotes

  1. 206 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@danking
Push get_item through wrapper arrays
60a587f 
Signed-off-by: Daniel King <dan@spiraldb.com>
@danking
danking force-pushed the dk/get-item-wrapper-pushdown branch from ee73b42 to 60a587f Compare September 3, 2026 19:09
@danking
danking merged commit 86d4a36 into develop Sep 3, 2026
82 of 83 checks passed
@danking
danking deleted the dk/get-item-wrapper-pushdown branch September 3, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 robert3005 approved these changes
@gatesn gatesn Awaiting requested review from gatesn
@joseph-isaacs joseph-isaacs Awaiting requested review from joseph-isaacs

Assignees

No one assigned

Labels

changelog/performance A performance improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danking @robert3005